Initial implementation of gpu_embedding. #2114
Open
+1,580
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The second part of the changes are in: |
zoranjovanovic-ns
force-pushed
the
gpu_embeddings
branch
from
9ae9192
to
7f0c638
Compare
|
@zoranjovanovic-ns it seems failed at cpu test //tensorflow/tools/api/tests:api_compatibility_test You need to check and reproduce it in your local. |
i-chaochen
reviewed
May 30, 2023
|
retest code-check please |
|
retest cpu-non-pip please |
I am running the tests locally, as soon as it pass I will retest everything. |
zoranjovanovic-ns
force-pushed
the
gpu_embeddings
branch
from
3b34e39
to
ee5302b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New gpu mid level API is not intended for large embedding table lookup.
Embedding tables will be replicated across devices rather than sharding across them.