fix hcc linking error caused by __fdividef #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
whchung
reviewed
Jun 13, 2018
|
ok to test |
|
Not tested yet -- this is a perfect need from NV CI.. |
|
@parallelo It seems "ok to test" doesn't really trigger the test.... guess I'm not admin? |
|
Jenkins: ok to test |
|
Let me check the Jenkins logs for the blocker.. |
|
Jenkins: add to whitelist |
|
Jenkins logs show: Jenkins: test this please |
|
Okay, all set. Next: figure out why the group whitelist isn't working properly with this Jenkins plugin. |
Merged
whchung
reviewed
Jun 13, 2018
| @@ -50,7 +50,7 @@ __global__ void InvVarianceToVarianceKernel(int nthreads, double epsilon, | |||
| int sample_size, T* variance) { | |||
| GPU_1D_KERNEL_LOOP(index, nthreads) { | |||
| T inv_var = variance[index]; | |||
| T var = __fdividef(1, inv_var * inv_var) - T(epsilon); | |||
There was a problem hiding this comment.
__fdividef() has some magic tricks in CUDA as it appears. I'd recommend using #if / #else to switch logic between CUDA and ROCm before we figure this out.
whchung
reviewed
Jun 13, 2018
sunway513
pushed a commit
that referenced
this pull request
Jun 20, 2018
fix hcc linking error caused by __fdividef
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes linking error with recent HIP updates on, thanks to @AlexVlx .