Enable custom all-reduce for ROCm. #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iotamudelta
commented
Jun 5, 2024
iotamudelta
commented
- add csrc custom_all_reduce into compilation
- add ops and pybindings
- do not disable custom all-reduce on ROCm in config
- port the custom all reduce source and test to HIP
- remove volatile signatures on ROCm
- optimized locking for ROCm
- increase default #threads and decrease #blocks after testing
* add csrc custom_all_reduce into compilation * add ops and pybindings * do not disable custom all-reduce on ROCm in config * port the custom all reduce source and test to HIP * remove volatile signatures on ROCm * optimized locking for ROCm * increase default #threads and decrease #blocks after testing
gshtras
reviewed
Jun 5, 2024
gshtras
reviewed
Jun 5, 2024
|
there is another pull request #27 for the same purpose. |
|
In light of #27 being merged, am closing this PR. If there are other components that you'd like to bring in here, please open a new PR with those changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.