Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick Replace kernel with a memory error (#1484) #1275

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

benjaminulmer
Copy link
Contributor

@AlexBrownAMD please double check that the updates look correct. Git merge handled them all automatically except for aldebaran/fp16altimpl, which I did manually.

Copy link
Contributor

@TorreZuk TorreZuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hotfix process from Andrew should be followed. Are no compiler fixes related to this landing?

@benjaminulmer
Copy link
Contributor Author

@TorreZuk @amcamd @lawruble13

We are going to step around the CQE staging tests (we will still run them in parallel) in an attempt to get this into mainline before the 5.4 branching.

@bragadeesh already conditionally approved this plan on Friday pending successful CI results.

@benjaminulmer benjaminulmer merged commit 1fa44e6 into ROCm:release/rocm-rel-5.4 Oct 18, 2022
babakpst pushed a commit to babakpst/rocBLAS that referenced this pull request Oct 28, 2022
Sphinx 5.0 includes the warning:

    WARNING: Invalid configuration value found: 'language = None'.
    Update your configuration to a valid langauge code.
    Falling back to 'en' (English).

The sphinx source code notes that sphinx-quickstart generated this
setting by default, however, an actual language is now expected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants