Hide symbols for GPU kernels #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -fvisibility=hidden flag does not affect kernels and thus all __global__ GPU functions become externally-visible symbols by default. Marking them as static will hide them. This is not strictly necessary, since the rocrand kernels are all appropriately confined to the rocrand details namespace. However, it is still useful to hide their symbols, as it is difficult to review ABI changes between different versions rocrand when the output of dpkg-gensymbols is full of kernels that change from release to release.
stanleytsang-amd
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
-fvisibility=hiddenflag does not affect kernels and thus all__global__GPU functions become externally-visible symbols by default. Marking them as static will hide them.This is not strictly necessary, since the rocrand kernels are all appropriately confined to the rocrand details namespace. However, it is still useful to hide their symbols, as it is difficult to review ABI changes between different versions of rocrand when the output of dpkg-gensymbols is full of kernels that change from release to release.