-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(coll work attrs)!: remove now-unnecessary userscript #246
Conversation
Codecov Report
@@ Coverage Diff @@
## main #246 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 886 886
Branches 163 163
=========================================
Hits 886 886 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should ship a last update first which notifies the users that the script is no longer necessary?
But I am not sure if a nagging alert()
message (as it has been done here) would be appropriate or if we should just blank the script and remove it. Then VM would show an error message once it fails to update the userscript, but I haven't checked what GM and TM do in that case.
Hmm that might be a good idea. Perhaps adding a banner to the page (the same as MB's own banner for e.g. beta updates) would be a compromise? I wouldn't go as far as implementing a "dismiss" button because the user should just uninstall the script. |
That's a very good and simple idea, it would only require injecting |
569ea77
to
7e6e9f1
Compare
See #253 for deprecation. Let's keep this one open for another few days to allow auto-updates to the deprecated version to take place. |
We've already deprecated the userscript in #253, now it's time to remove it.
7e6e9f1
to
f7cb5eb
Compare
MB now collapses work attributes itself: MBS-11537. They're collapsed on all pages on which we collapse work attributes (works themselves, work tables in artist pages and collections, and edit pages). Therefore, this userscript is now unnecessary and can be removed.
Closes #242