Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(coll work attrs)!: remove now-unnecessary userscript #246

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

ROpdebee
Copy link
Owner

MB now collapses work attributes itself: MBS-11537. They're collapsed on all pages on which we collapse work attributes (works themselves, work tables in artist pages and collections, and edit pages). Therefore, this userscript is now unnecessary and can be removed.

Closes #242

@codecov
Copy link

codecov bot commented Nov 17, 2021

Codecov Report

Merging #246 (f7cb5eb) into main (579b2ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #246   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           40        40           
  Lines          886       886           
  Branches       163       163           
=========================================
  Hits           886       886           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 579b2ad...f7cb5eb. Read the comment docs.

Copy link
Collaborator

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should ship a last update first which notifies the users that the script is no longer necessary?
But I am not sure if a nagging alert() message (as it has been done here) would be appropriate or if we should just blank the script and remove it. Then VM would show an error message once it fails to update the userscript, but I haven't checked what GM and TM do in that case.

@ROpdebee
Copy link
Owner Author

Hmm that might be a good idea. Perhaps adding a banner to the page (the same as MB's own banner for e.g. beta updates) would be a compromise? I wouldn't go as far as implementing a "dismiss" button because the user should just uninstall the script.

@kellnerd
Copy link
Collaborator

That's a very good and simple idea, it would only require injecting <div class="banner warning-header"><p>Please uninstall X...</p></div> before #page (I just tested it with the dev tools).

@ROpdebee
Copy link
Owner Author

See #253 for deprecation. Let's keep this one open for another few days to allow auto-updates to the deprecated version to take place.

We've already deprecated the userscript in #253, now it's time to
remove it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate/remove collapse work attrs script
2 participants