Skip to content

Commit

Permalink
Remove redondant "virtual" keyword when "override" is used
Browse files Browse the repository at this point in the history
  • Loading branch information
scribam authored and Nekotekina committed Dec 10, 2017
1 parent 50f2be5 commit c2ae7ee
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions Utilities/JIT.cpp
Expand Up @@ -171,7 +171,7 @@ struct MemoryManager : llvm::RTDyldMemoryManager
return {addr, llvm::JITSymbolFlags::Exported};
}

virtual u8* allocateCodeSection(std::uintptr_t size, uint align, uint sec_id, llvm::StringRef sec_name) override
u8* allocateCodeSection(std::uintptr_t size, uint align, uint sec_id, llvm::StringRef sec_name) override
{
// Lock memory manager
writer_lock lock(s_mutex);
Expand All @@ -192,7 +192,7 @@ struct MemoryManager : llvm::RTDyldMemoryManager
return (u8*)std::exchange(s_next, (void*)next);
}

virtual u8* allocateDataSection(std::uintptr_t size, uint align, uint sec_id, llvm::StringRef sec_name, bool is_ro) override
u8* allocateDataSection(std::uintptr_t size, uint align, uint sec_id, llvm::StringRef sec_name, bool is_ro) override
{
// Lock memory manager
writer_lock lock(s_mutex);
Expand All @@ -217,7 +217,7 @@ struct MemoryManager : llvm::RTDyldMemoryManager
return (u8*)std::exchange(s_next, (void*)next);
}

virtual bool finalizeMemory(std::string* = nullptr) override
bool finalizeMemory(std::string* = nullptr) override
{
// Lock memory manager
writer_lock lock(s_mutex);
Expand All @@ -234,7 +234,7 @@ struct MemoryManager : llvm::RTDyldMemoryManager
return false;
}

virtual void registerEHFrames(u8* addr, u64 load_addr, std::size_t size) override
void registerEHFrames(u8* addr, u64 load_addr, std::size_t size) override
{
#ifdef _WIN32
// Lock memory manager
Expand Down Expand Up @@ -266,7 +266,7 @@ struct MemoryManager : llvm::RTDyldMemoryManager
return RTDyldMemoryManager::registerEHFrames(addr, load_addr, size);
}

virtual void deregisterEHFrames(u8* addr, u64 load_addr, std::size_t size) override
void deregisterEHFrames(u8* addr, u64 load_addr, std::size_t size) override
{
LOG_ERROR(GENERAL, "deregisterEHFrames() called"); // Not expected

Expand All @@ -284,7 +284,7 @@ struct EventListener : llvm::JITEventListener
{
}

virtual void NotifyObjectEmitted(const llvm::object::ObjectFile& obj, const llvm::RuntimeDyld::LoadedObjectInfo& inf) override
void NotifyObjectEmitted(const llvm::object::ObjectFile& obj, const llvm::RuntimeDyld::LoadedObjectInfo& inf) override
{
#ifdef _WIN32
for (auto it = obj.section_begin(), end = obj.section_end(); it != end; ++it)
Expand Down

0 comments on commit c2ae7ee

Please sign in to comment.