Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] [macOS Arm] Build: Compilation fails with Apple Clang after PR 13872 #13882

Closed
shinra-electric opened this issue May 18, 2023 · 10 comments · Fixed by #13881
Closed

Comments

@shinra-electric
Copy link
Contributor

Quick summary

Compilation failure when building an Arm target on an M1 Mac with Apple Clang.

Details

Prior to the PR compilation is successful (#13863)

Building after the PR fails (#13872)

Logs below.

The file affected is util/media_utils.cpp

Build with regression

#13872

Attach two log files

Terminal Output 13863(Success).txt
Terminal Output 13872(Failure).txt

Attach capture files for visual issues

No response

System configuration

M1 Pro
Ventura 13.3.1
16GB

Other details

No response

@Megamouse
Copy link
Contributor

try #13881

@Megamouse
Copy link
Contributor

specifically 8641001

@shinra-electric
Copy link
Contributor Author

I edited the following two lines from the commit, but it still didn't build:

std::string(codec->name ? codec->name : "unknown"),
std::string(codec->long_name ? codec->long_name : "unknown")

@Megamouse
Copy link
Contributor

try this instead 088e225

@shinra-electric
Copy link
Contributor Author

Yep, that fixed it.

@kd-11
Copy link
Contributor

kd-11 commented May 18, 2023

Can we get updated macos build instructions somewhere? I've found working on the platform to be a nightmare.
I don't think anything I compile actually runs on M1.

@shinra-electric
Copy link
Contributor Author

@kd-11 This is what I use.
RPCS3 Build instructions.txt

Right now LLVM is broken, the Arm build only runs with PPU decoder set to Static interpreter, and the SPU decoder set to Dynamic interpreter. See #12882 for details. (Although I've edited and amended that issue so much over time it might be better just to close it and open a new one).

@shinra-electric
Copy link
Contributor Author

shinra-electric commented May 18, 2023

Looks like one of the recent Qt PRs affected the game library though, nothing is loading. I'll try to check which one..
Edit: it was the Midi one

@kd-11
Copy link
Contributor

kd-11 commented May 18, 2023

@kd-11 This is what I use. RPCS3 Build instructions.txt

Right now LLVM is broken, the Arm build only runs with PPU decoder set to Static interpreter, and the SPU decoder set to Dynamic interpreter. See #12882 for details. (Although I've edited and amended that issue so much over time it might be better just to close it and open a new one).

Thanks. How does the x64 build differ? Just the build targets?

@shinra-electric
Copy link
Contributor Author

shinra-electric commented May 18, 2023

I presume so, but I haven't built for x64 before so I'm not sure if anything special is needed.

Edit: Actually, I think x64 versions of all the homebrew dependencies need to be installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants