Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Default Vulkan as video renderer #14205

Closed
rtritto opened this issue Jul 16, 2023 · 2 comments · Fixed by #14209
Closed

[Regression] Default Vulkan as video renderer #14205

rtritto opened this issue Jul 16, 2023 · 2 comments · Fixed by #14209
Assignees

Comments

@rtritto
Copy link

rtritto commented Jul 16, 2023

Quick summary

Before #14153, the default video renderer was Vulkan

config.yml

Video:
  Renderer: Vulkan
  Vulkan:
    Adapter: <DEFAULT_GPU_NAME>

After, it's changed to OpenGL

config.yml

Video:
  Renderer: OpenGL
  Vulkan:
    Adapter: ""

Details

No response

Build with regression

0.0.28-15335-e2c2ef97

Attach two log files

No response

Attach capture files for visual issues

No response

System configuration

No response

Other details

No response

@illusion0001
Copy link
Contributor

cfg::_enum<video_renderer> renderer{ this, "Renderer", video_renderer::opengl };
it was always opengl?

@Megamouse
Copy link
Contributor

cfg::_enum<video_renderer> renderer{ this, "Renderer", video_renderer::opengl };

it was always opengl?

No. It was always patched during runtime.
I accidentally put the new code that saves a new default config right before the patch though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants