Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: Possible PR #6357 Regression #6379

Closed
darkash opened this issue Aug 19, 2019 · 19 comments
Closed

Vulkan: Possible PR #6357 Regression #6379

darkash opened this issue Aug 19, 2019 · 19 comments
Assignees

Comments

@darkash
Copy link

darkash commented Aug 19, 2019

build 8534 has black bar upon save point prompt
image
RPCS3-8534.zip

build 8531, no black bar
image
RPCS3-8531.log.gz

Operating System:
Windows 10 build 1903
Ram: 8 GB
CPU: i7-8550U
GPU: Nvidia Geforce MX130

Additional Note:
I tried removing all cache and deleting config.yml as well as custom config and the issue still persists.

You might notice that both have different fps counters, but both has been using the same config I generated from build 8534, and if u checked through log both vblank is still default value, so I have no idea why one of them has the fps unlocked somehow while older version locked it to 57 fps and even dips for me.

@Asinin3
Copy link
Contributor

Asinin3 commented Aug 19, 2019

Be sure to tag the Pull Request in the description/comment as well so the developer see's it like so: #6357 It doesn't work if you just put it in the title.

@kd-11
Copy link
Contributor

kd-11 commented Aug 19, 2019

Need RSX capture from the 'good build'

@darkash
Copy link
Author

darkash commented Aug 20, 2019

affirmative, will be doing that once I'm home from work.
In the meantime, I will need to know how to enable/do that. Will appreciate if someone point it out to me, thanks :D

@RainbowCookie32
Copy link
Contributor

On RPCS3 go to View, and click Show debugger. Now you have the debugger open on RPCS3's window. Run the game and when you have the issue on screen, click RSX Capture on the debugger. The capture should be saved to captures in RPCS3's folder, you can compress it which usually reduces its size considerably

@Realmantik
Copy link

Realmantik commented Aug 20, 2019

@kd-11
Copy link
Contributor

kd-11 commented Aug 20, 2019

Come on guys, please add screenshots. I don't really know what any of these games are supposed to look like ingame, which means its easy to miss bugs.

@kd-11 kd-11 self-assigned this Aug 20, 2019
@Realmantik
Copy link

Realmantik commented Aug 20, 2019

No matter Vulkan or OpenGL.
screenshot-2019_08_20_17_50_30
screenshot-2019_08_20_17_51_39

@stride21
Copy link

stride21 commented Aug 20, 2019

Killzone 3 regressed with this PR as well but when using RSX capture it would crash the majority of the time but luckily I got one of the PR, I hope its correct. I still haven't been able to get a RSX capture of the previous build but I can keep trying later if its necessary.
Before:
before
After:
PR
RSX Capture

@kd-11
Copy link
Contributor

kd-11 commented Aug 20, 2019

I'm pretty sure these are all one bug (blit engine). I'll push a fix soon.

@darkash
Copy link
Author

darkash commented Aug 20, 2019

Here, the RSX capture from last "good build" for me
image
BLUS30639_20190821015340_capture.zip
RPCS3.log.gz

Thanks in advance :)

@kd-11
Copy link
Contributor

kd-11 commented Aug 20, 2019

I genuinely wonder if this is better with the text overflowing out of the prompt box.

@kd-11
Copy link
Contributor

kd-11 commented Aug 20, 2019

Fixed by #6376

@kd-11 kd-11 mentioned this issue Aug 20, 2019
@Realmantik
Copy link

The bug with half screen in Tales of Vesperia is not fixed.

@kd-11
Copy link
Contributor

kd-11 commented Aug 20, 2019

But I just pushed the code a few minutes ago.

@kd-11
Copy link
Contributor

kd-11 commented Aug 20, 2019

Looks like there is a regression in MSAA code, I'll push a fix shortly.

@kd-11
Copy link
Contributor

kd-11 commented Aug 20, 2019

Fixed now.

@darkash
Copy link
Author

darkash commented Aug 21, 2019

I genuinely wonder if this is better with the text overflowing out of the prompt box.

you can blame NISA for that lol

anyway, I will test the PR once I got home again, thanks for the hard work!

@Realmantik
Copy link

Yes, it is fixed. Cool. Great work!

@darkash
Copy link
Author

darkash commented Aug 21, 2019

confirmed it to be fixed with PR #6376 , many thanks

will close this issue now since it's been merged to master as well

@darkash darkash closed this as completed Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants