Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need for Speed Most Wanted Debug Builds - issues #7418

Open
5 of 8 tasks
CookiePLMonster opened this issue Feb 7, 2020 · 1 comment
Open
5 of 8 tasks

Need for Speed Most Wanted Debug Builds - issues #7418

CookiePLMonster opened this issue Feb 7, 2020 · 1 comment

Comments

@CookiePLMonster
Copy link
Contributor

CookiePLMonster commented Feb 7, 2020

As of now, NFS MW prototypes/debug builds are circulated together with a "custom" RPCS3 build patching up missing functionality and merging code which is crucial for those games to function, yet somehow did not get to master. This is a meta issue aimed to find all missing pieces so those builds can eventually run on master, without having to resort to custom, possibly outdated builds.

  • cellSearch implementation - at least one prototype seems to require cellSearch to work somewhat properly, else it throws an unskippable assertion on start. Custom builds merge [WIP] cellSearch + VFS Linking #4714 to get it to work.
  • PSN spoof - in order to proceed to the game, at least one prototype requires "PSN spoof" - as in, RPCS3 needs to pretend PSN is online. This also seems to affect some non-debug NFS games, such as NFS Hot Pursuit. Consider allowing RPCS3 to pretend PSN is online and just act as if servers were unreachable or something. Custom builds use clienthax@8f31a1e to spoof online PSN state.
  • Saves - there is some (yet unknown) difference in save data handling between RPCS3 and real PS3. On RPCS3, MW prototypes will reject each other's save data and softlock with an error: https://cdn.discordapp.com/attachments/639167048165097472/639499032422645760/unknown.png
    This doesn't happen on the console.
    Additionally, running with a debugger attached exposes some odd timing issue, which may sadly be a game bug: https://cdn.discordapp.com/attachments/635144592534011958/676022990747598858/unknown.png
  • [WIP] SPU LLVM: use FMA with approx xfloat when available #7118 reportedly breaks sound in all Most Wanted games. Sound has always been broken in MW with Accurate xfloat, so looks like this PR increased accuracy of Approximate xfloat just enough for sound to break. Puzzling.
  • Audit failure with PS3 Launcher app with running it with Write Color Buffers and vulkan:
    AUDIT(!g_cfg.video.write_color_buffers && !g_cfg.video.write_depth_buffer);
    call stack:
rpcs3d.exe!rsx::texture_cache<vk::texture_cache,vk::texture_cache_traits>::commit_framebuffer_memory_region<>(vk::command_buffer & cmd, const utils::address_range & rsx_range) Line 1165    C++
>    rpcs3d.exe!VKGSRender::prepare_rtts(rsx::framebuffer_creation_context context) Line 2880    C++
     rpcs3d.exe!VKGSRender::init_buffers(rsx::framebuffer_creation_context context, bool __formal) Line 2647    C++
     rpcs3d.exe!VKGSRender::clear_surface(unsigned int mask) Line 1930    C++
     rpcs3d.exe!rsx::nv4097::clear(rsx::thread * rsx, unsigned int _reg, unsigned int arg) Line 172    C++
     rpcs3d.exe!rsx::thread::run_FIFO() Line 573    C++
@Ordinary205
Copy link
Contributor

Ordinary205 commented May 6, 2023

Need for speed Most Wanted/The Run no longer requires Accurate XFloat or ASMJIT in order to fix a broken audio thanks to this PR #13723.

Note: The audio will break if it is set to Relaxed XFloat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants