Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Pirate Warriors 2 Seizuring Enemy AI [BLES01913] (Broken with SPU llvm Safe) #7958

Closed
TheProtato923 opened this issue Apr 5, 2020 · 6 comments · Fixed by #8316

Comments

@TheProtato923
Copy link

TheProtato923 commented Apr 5, 2020

Quick summary

Enemy AI seems to have a literal seizure and flicker around uncontrollably.

Details

Regression was introduced in build 9806, and was not present in 9805.

Log for 9806 - https://drive.google.com/file/d/1V1SY8WCLScuzhNbWtQmyeWA_DTB-ajPQ/view?usp=sharing
Log for 9805 - https://drive.google.com/file/d/17OxJqU6Wp4mRD1Dd7mQDRoaSMySdgI8K/view?usp=sharing

RSX Capture - https://drive.google.com/file/d/1wvM8fHEg_tXVAGoYOiFrDy2qHlOWmSph/view?usp=sharing

Screenshot
78504776-296de600-773d-11ea-98e7-440b30812f07

@TheProtato923 TheProtato923 changed the title Visual Bug: Pirate Warriors 2 Seizuring Enemy AI [BLES01913] Regression: Pirate Warriors 2 Seizuring Enemy AI [BLES01913] Apr 5, 2020
@RainbowCookie32
Copy link
Contributor

Offending PR is #7672 then

@TheProtato923 TheProtato923 changed the title Regression: Pirate Warriors 2 Seizuring Enemy AI [BLES01913] Regression: Pirate Warriors 2 Seizuring Enemy AI [BLES01913] (Broken with SPU llvm Safe) Apr 5, 2020
@AniLeo
Copy link
Member

AniLeo commented Apr 5, 2020

Note: This works with Accurate XFloat, but before it didn't require it to render properly

@arcadee1977
Copy link

Note: This works with Accurate XFloat, but before it didn't require it to render properly

Dynasty Warriors: Gundam Reborn|BLES02057 have the same problem

@Whatcookie
Copy link
Member

Issue can be reopened, apparently the version I PR'd didn't solve this issue.

I can solve it now, but it will come with a noticeable performance loss. I think I can solve it without causing any performance loss at all, but it will take much longer to write. I'll probably work on some other stuff and revisit it at a later date.

@kd-11 kd-11 reopened this Jun 2, 2020
@AniLeo
Copy link
Member

AniLeo commented Jun 2, 2020

For reference, One Piece was fixed by the FMA32x4 change and then rebroke with FM change

@digitaldude555
Copy link

digitaldude555 commented Jan 26, 2021

Its fixed now with spu llvm safe accurate xfloat isnt needed.

@MSuih MSuih closed this as completed Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants