Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused dependencies #1056

Closed
xdy opened this issue Dec 31, 2019 · 3 comments · Fixed by #3807
Closed

Remove unused dependencies #1056

xdy opened this issue Dec 31, 2019 · 3 comments · Fixed by #3807
Assignees
@thelsing
Labels
build-configuration tested This issue has been QA tested by someone other than the developer.

Comments

@xdy
Copy link
Collaborator

xdy commented Dec 31, 2019 •
edited

Intended to be a sub-issue of #1041
Initially I'll run https://github.com/nebula-plugins/gradle-lint-plugin/wiki on the project.
Seems I'll also need to make PR:s on the other rptools projects maptool depends on. I won't make issues for those, just reference this issue in those PR:s. (I know I'm in a minority, but, well, I like monorepos. I'm lazy. :)
@xdy xdy mentioned this issue Dec 31, 2019
Open
@Phergus Phergus added this to Needs triage in Backlog via automation Dec 31, 2019
@xdy
Copy link
Collaborator Author

xdy commented Jan 12, 2020

Done first round of PR:s on the sub-projects (upgrade gradle to 5.3.1)
RPTools/clientserver#11
RPTools/parser#17
RPTools/maptool-resources#1
RPTools/dicelib#20

I'll unassign myself from this one for now, if anyone feels like grabbing it, go ahead.

@xdy xdy removed their assignment Jan 12, 2020
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove jlayer dependency
cd2110a 
- Remove unused jlayer dependency and SoundPlayer class
- Check RPTools#1056 for a general discussion of dependencies removal
@Merudo Merudo mentioned this issue Jan 25, 2020
Merged
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
cf444bb 
- Remove 24 unused dependencies found by gradlelint
- Change jide-shortcut and maptool.resource to runtimeOnly dependencies as recommended by gradlelint
- RPTools#1056 for a general discussion of dependencies removal
@Merudo Merudo mentioned this issue Jan 25, 2020
Closed
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
2b6002e 
- Remove 23 unused dependencies found by gradlelint
- Change jide-shortcut and maptool.resource to runtimeOnly dependencies as recommended by gradlelint
- Unchanged org.slf4j, which is detected as unused by gradlelint but is used by SLF4J logger
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
c437bd7 
- Remove 23 unused dependencies found by gradlelint
- Change jide-shortcut and maptool.resource to runtimeOnly dependencies as recommended by gradlelint
- Change org.slf4j to runtimeDependency. It is detected as unused by gradlelint but is used by SLF4J logger
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
b050b9f 
- Remove 23 unused dependencies found by gradlelint
- Change jide-shortcut and maptool.resource to runtimeOnly dependencies as recommended by gradlelint
- Change org.slf4j to runtimeOnly. The dependency is detected as unused by gradlelint but is used by SLF4J logger
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
a734d8a 
- Remove 22 unused dependencies found by gradlelint
- Change jide-shortcut and maptool.resource to runtimeOnly dependencies as recommended by gradlelint
- Change org.slf4j to runtimeOnly. It is  used by SLF4J logger.
- Change jxpath to runtimeOnly. It is used by the DiscoveryListener daemon
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Update build.gradle
f770ef6 
- Remove 21 unused dependencies found by gradlelint
- Change to runtimeOnly: jide-shortcut, maptool.resource, slf4j-simple, jxpath, commons-jxpath, and jai-imageio-core
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
368a9b8 
- Remove 21 unused dependencies found by gradlelint
- Change to runtimeOnly: jide-shortcut, maptool.resource, slf4j-simple, jxpath, commons-jxpath, jai-imageio-core, and bcmail-jdk15on
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
ea0bf51 
- Remove 17 unused dependencies found by gradlelint
- Change to runtimeOnly: jide-shortcut, maptool.resource, slf4j-simple, jxpath, commons-jxpath, jai-imageio-core, imageio-core, imageio-jpeg, imageio-psd, and bcmail-jdk15on
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
eb6331e 
- Remove 16 unused dependencies found by gradlelint
- Change to runtimeOnly: jide-shortcut, maptool.resource, slf4j-simple, jxpath, commons-jxpath, jai-imageio-core, imageio-core, imageio-jpeg, imageio-psd, xpp3_min, and bcmail-jdk15on
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
e21c0e1 
- Remove 14 unused dependencies found by gradlelint
- Change to runtimeOnly: jide-shortcut, maptool.resource, slf4j-simple, jxpath, commons-jxpath, ezmorph, jai-imageio-core, imageio-core, imageio-jpeg, imageio-psd, xpp3_min, xmlpull, and bcmail-jdk15on
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
a2f50ba 
- Remove 12 unused dependencies found by gradlelint
- Change to runtimeOnly:  jide-shortcut, maptool.resource, commons-logging, commons-beanutils, slf4j-simple, jxpath, commons-jxpath, ezmorph, jai-imageio-core, imageio-core, imageio-jpeg, imageio-psd, xpp3_min, xmlpull, and bcmail-jdk15on
- RPTools#1056 for a general discussion of dependencies removal
Merudo added a commit to Merudo/maptool that referenced this issue Jan 25, 2020
@Merudo
Remove unused dependencies found by gradlelint
9f95ff7 
- Remove 11 unused dependencies found by gradlelint
- Change to runtimeOnly: jide-shortcut, maptool.resource, commons-logging, commons-beanutils, slf4j-simple, jxpath, commons-jxpath, ezmorph, jai-imageio-core, imageio-core, imageio-jpeg, imageio-psd, xpp3_min, xmlpull, and bcmail-jdk15on
- RPTools#1056 for a general discussion of dependencies removal
@Merudo
Copy link
Member

Merudo commented Jan 25, 2020 •
edited

I believe the 11 following dependencies are unused:

  • Antlr: added before 1.4, used to compile other RPTools project but not this one
  • decktool: added before 1.4, appears to be at the prototype stage
  • 4 jide dependencies: not needed by the jide elements we use
  • jetty-servlet, websocket-client: added before 1.4, not used by webapp
  • jetty-continuation: deprecated, added before 1.4, not used by webapp
  • ca.odell.renderpack: fetched from Craig's website. Contains class HTMLTableCellRenderer, HTMLRenderer, HTMLListCellRenderer, but these are not used. Added before 1.4.
  • mockito-core: for mocking features during unit tests, but is not used by any test. Added in 1.5.0.

@Phergus Phergus added this to To do in MapTool 1.6.0 via automation Jan 25, 2020
@Phergus Phergus removed this from Needs triage in Backlog Jan 25, 2020
@Phergus Phergus added this to To do in MapTool 1.6.0 the Sequel via automation Mar 3, 2020
@Phergus Phergus removed this from To do in MapTool 1.6.0 Mar 3, 2020
@Phergus Phergus removed this from To do in MapTool 1.6.0 the Sequel Apr 3, 2020
@thelsing thelsing assigned thelsing and unassigned Merudo Dec 30, 2022
@thelsing thelsing mentioned this issue Jan 2, 2023
Merged
@Phergus
Copy link
Contributor

Phergus commented Feb 20, 2023

Builds and runs after changes.

@Phergus Phergus added the tested This issue has been QA tested by someone other than the developer. label Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thelsing thelsing

Labels
build-configuration tested This issue has been QA tested by someone other than the developer.
Projects
MapTool 1.13.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature reduce deps thelsing/maptool
4 participants
@xdy @Merudo @thelsing @Phergus