Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Unexpected Error Popup When Trying to Connect to Non-existent Server #3884

Closed
viggyd opened this issue Mar 27, 2023 · 1 comment · Fixed by #3898
Closed

[Bug]: Unexpected Error Popup When Trying to Connect to Non-existent Server #3884

viggyd opened this issue Mar 27, 2023 · 1 comment · Fixed by #3898
Assignees
@viggyd
Labels
bug

Comments

@viggyd
Copy link
Contributor

viggyd commented Mar 27, 2023

Describe the Bug

When trying to connect to a server that is not online or doesn't exist, I get an error message popup.
image

Here's the error:
image

To Reproduce

  1. Go to File > Connect to Server...
  2. Put a non-existent name in Server Name
  3. Hit OK
  4. Observe error shown above

Expected Behaviour

At step 4, I expected to see a basic popup saying something along the lines of "Server not found", rather than a stack trace.

Screenshots

No response

MapTool Info

Version: Latest develop branch

Desktop

Windows

Additional Context

I saw this issue initially on v1.8.3, but I checked and also saw it on commit 98e076
@viggyd viggyd added the bug label Mar 27, 2023
@viggyd
Copy link
Contributor Author

viggyd commented Mar 28, 2023

I can work on this issue, it should be pretty simple to fix

@viggyd viggyd mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viggyd viggyd

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catch JSON Exception When Attempting to Connect to Server viggyd/maptool
1 participant
@viggyd