Catch JSON Exception When Attempting to Connect to Server #3898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to connect to a server, the application will attempt to parse the return string as a JSON object. However, if the server doesn't exist, a `null` string is returned. When trying to convert this to JSON, there's an `IllegalStateException` and then the error pops up to the user. After adding this body check, the application is able to resolve the error gracefully. It will pop up a short dialog saying "Server "x" is not found" or some such.
cwisniew
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix or Enhancement
and possibly closure of the pull request if it is not provided after this request.
Identify the Bug or Feature request
Fixes #3884
Description of the Change
When trying to connect to a server, the application will attempt to parse the return string as a JSON object. However, if the server doesn't exist, a
nullstring is returned. When trying to convert this to JSON, there's anIllegalStateExceptionand then the error pops up to the user.After adding this body check, the application is able to resolve the error gracefully. It will pop up a short dialog saying "Server "x" is not found" or some such.
Possible Drawbacks
I cannot think of any. The added code does some minor error handling, it should not introduce any adverse effects.
Documentation Notes
N/A
Release Notes
This change is