Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the empty space at the bottom of input() dialog #1289

Merged
merged 5 commits into from Feb 19, 2020

Conversation

emmebi
Copy link
Collaborator

@emmebi emmebi commented Feb 16, 2020

The solution found was to change the LayoutManager in the JOptionPane to a GridBagLaout, and
set the proper constraints on the existing components in the new LayoutManager.

Refers to #198


This change is Reviewable

The solution found was to change the LayoutManager in the JOptionPane to a GridBagLaout, and
set the proper constraints on the existing components in the new LayoutManager.

Refers to RPTools#198
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Phergus Phergus added this to In progress in MapTool 1.6.0 via automation Feb 16, 2020
MapTool 1.6.0 automation moved this from In progress to Reviewer approved Feb 19, 2020
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Phergus Phergus merged commit 07dbdd2 into RPTools:develop Feb 19, 2020
MapTool 1.6.0 automation moved this from Reviewer approved to Done Feb 19, 2020
@Merudo Merudo mentioned this pull request Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
MapTool 1.6.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants