Extend MapToolScriptTokenMaker #241
Conversation
Signed-off-by: Jamz <Jamz@Nerps.net>
* MapToolScriptSyntax now dynamically adds in all function names retrieved by the MapToolLineParser * AutoCompletion turned on for Macro Editor! meta+space to activate * Macro short descriptions and summary text needs to be added. Currently loading from a properties file. * Some refactoring... Signed-off-by: Jamz <Jamz@Nerps.net>
Signed-off-by: Jamz <Jamz@Nerps.net>
Signed-off-by: Jamz <Jamz@Nerps.net>
There was a problem hiding this comment.
My only concerns are regarding the i18n stuff. I don't see any value in putting getString(String, ResourceBundle) into I18N. And the macro properties file has a really large string for "abort.summary"; please break it up by putting backslash-newline after each "\n" in the string. This will allow the text to span multiple physical lines. Thanks!
Reviewed 17 of 19 files at r1.
Reviewable status: 17 of 19 files reviewed, all discussions resolved (waiting on @Azhrei and @cwisniew)
There was a problem hiding this comment.
To be honest, was kinda of throwing it together. adding the new getString just seemed like a way to reuse the i18n stuff in case we wanted to break things up more in the future. Do you just want me to add the static final location in the i18n instead? I have no strong feeling either way.
What's the purpose of breaking up the .properties line? No strong feelings but curious why? I honestly just did a quick/dirty copy from HTML source there as well just for a sample and test how it will look. It looked fine but it will obviously change once we get a real dump of the source.
Reviewable status: 17 of 19 files reviewed, all discussions resolved (waiting on @cwisniew)
|
I'm going to merge this for now but consider it WIP and may change as we solidify how to handle macro descriptions. |
|
Ok not sure why Travis reports yellow, it completed successfully. I will return job and see what happens. |
|
I18N might be fine place for it, but then some reorg is needed. The long line will freak out some tools (like GH Reviewable!) and makes it difficult to see changes to one word (because the whole line is in the diff). No big deal from a functionality standpoint. |
|
What reorg do you have in mind? And all valid points re long line, makes sense, I can make that happen. |
Signed-off-by: Jamz <Jamz@Nerps.net>
PR for Issue #239 & #240
This change is