Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #107 add native token width/height functions #309

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Fix #107 add native token width/height functions #309

merged 1 commit into from
Mar 22, 2019

Conversation

source-knights
Copy link
Contributor

@source-knights source-knights commented Mar 15, 2019 •
edited by cwisniew

This change is Reviewable

@source-knights source-knights mentioned this pull request Mar 15, 2019
Closed
@JamzTheMan JamzTheMan closed this Mar 18, 2019
@JamzTheMan JamzTheMan changed the base branch from merge-from-nerps to develop March 18, 2019 13:29
@JamzTheMan
Copy link
Member

We're cleaning up our Repo to follow GitFlow. I've targeted this against our Develop branch now.

@JamzTheMan JamzTheMan reopened this Mar 18, 2019
@cwisniew cwisniew added this to PR Created in MapTool 1.5.1 via automation Mar 20, 2019
cwisniew
cwisniew approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@cwisniew cwisniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@cwisniew cwisniew merged commit d4e5912 into RPTools:develop Mar 22, 2019
MapTool 1.5.1 automation moved this from PR Created to Done Mar 22, 2019
@rkathey
Copy link
Contributor

rkathey commented Mar 23, 2019

Tested. Seems to follow the normal pattern of the id parameter. Are there other parameters to test?
(note: no wiki entry yet)

[h:id=currentToken()]
[r:getTokenNativeHeight()]
[r:getTokenNativeWidth()]
[r:getTokenNativeHeight(id)]
[r:getTokenNativeWidth(id)]

@JamzTheMan JamzTheMan added low Low priority bug/enhancement 1 claimed Issue is being actively worked on. tested This issue has been QA tested by someone other than the developer. labels Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwisniew cwisniew cwisniew approved these changes

Assignees
No one assigned
Labels
claimed Issue is being actively worked on. low Low priority bug/enhancement tested This issue has been QA tested by someone other than the developer.
Projects
No open projects
MapTool 1.5.1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@source-knights @JamzTheMan @rkathey @cwisniew