Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Adjust Grid panel bugs #3704

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

Phergus
Copy link
Contributor

@Phergus Phergus commented Oct 7, 2022

Identify the Bug or Feature request

Fixes #3702
Fixes #3703

Description of the Change

  • Fixed a typo in Grid.toDto() method that caused offsets to get messed up.
  • Fixed an issue where initialization of the size spinner in the Adjust Grid panel was causing the grid to be reset.

Possible Drawbacks

None hopefully.

Documentation Notes

No change to intended functionality.

Release Notes

  • Fixes grid offsets and grid color being reset when starting server or when opening the Adjust Grid on an existing map.

This change is Reviewable

Correct typo on offset.
Additional fix for RPTools#3703.
@Phergus Phergus added this to In progress in MapTool 1.12 via automation Oct 7, 2022
MapTool 1.12 automation moved this from In progress to Reviewer approved Oct 7, 2022
@Phergus Phergus merged commit 899add1 into RPTools:develop Oct 7, 2022
@Phergus Phergus deleted the issue3702gridOffsetFix branch October 7, 2022 19:16
@Phergus Phergus moved this from Reviewer approved to Done in MapTool 1.12 Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[Bug]: Grid offset gets reset for loaded maps [Bug]: Grid offsets changed on server start
2 participants