Readd compression #3753
Merged
Readd compression #3753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove commented out code
Phergus
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @thelsing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
connected to #3254
Description of the Change
With 1.12 connecting times became slower because hessian used to compress messages with gzip. Until now protobuf messages are not compressed. This leads to a noticeable increase of time to connect to a server with bigger campaigns.
This commit adds lzma compression to fix this.
I also added some more INFO logging on who sends messages to help to notice delays. HEARTBEAT messages are only logged as DEBUG now to avoid cluttering the log.
Last not least I noticed a harmless warning in the logs when Pens without colors were serialized. This small fix is also included.
Possible Drawbacks
Release Notes
This change is