make playerAlias getter return null if not DisplayName was set. Accou… #3787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt for that change. Centralize generation of String from map in ToString of zone.
Phergus
approved these changes
Dec 23, 2022
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @thelsing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nt for that change. Centralize generation of String from map in ToString of zone.
Identify the Bug or Feature request
fixes 3247
Description of the Change
Make playerAlias getter return null if not DisplayName was set. Account for that change. Centralize generation of String from map in ToString of zone.
Possible Drawbacks
Maybe some code depends on zone.toString() to only display the name. I didn't find anything like that though.
Release Notes
This change is