Refactor: Remove ReverseShapePathIterator in favour of JTS' Polygonizer #3825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new method is `GeometryUtil.toJts()`. This uses to the precision model already present in `GeometryUtil`, while also using a newly added `GeometryFactory`. That `GeometryFactory` is also exposed so that other components can be sure to use a matching factory.
In addition to relying on `GeometryUtil.toJts()`, `FogUtil` also uses its `GeometryUtil.getGeometryFactory()` instead of creating its own.
Phergus
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Implements #3484
Description of the Change
The
ReverseShapePathIteratorwas added to shuffle the results of aPathIteratorin such a way that JTS'ShapeReader.read()will correctly recognize holes in the polygons. This PR introduces a more robust approach that uses JTS'Polygonizerwhich is capable of assemblingLineStrings into polygons with holes without us needing to mess with the input first.During the conversion, we also make sure the coordinates respect the precision model by calling
makePrecise()on them before passing them off to thePolygonizer.Possible Drawbacks
Polygonizer, especially for maps with lots of complex topology.Polygonizerand existing behaviour.Documentation Notes
N/A (internal change)
Release Notes
N/A (internal change)
This change is