Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include temporary token light sources #3830

Conversation

kwvanderlinde
Copy link
Collaborator

@kwvanderlinde kwvanderlinde commented Jan 31, 2023

Identify the Bug or Feature request

Fixes problem with #3747 added in #3813

Description of the Change

In PR #3813, some special logic was missed for including light sources for temporary tokens, which are used for the Expose Last Path operation. This PR adds in the equivalent logic for the new lighting.

Possible Drawbacks

Shouldn't be any.

Documentation Notes

N/A

Release Notes

N/A


This change is Reviewable

This adds back in necessary functionality for Expose Last Path to function correctly.
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)

@Phergus Phergus merged commit 71d9abf into RPTools:develop Feb 4, 2023
@kwvanderlinde kwvanderlinde deleted the bugfix/3747-restore-support-for-temporary-tokens branch March 6, 2023 00:09
@cwisniew cwisniew added the performance A performance or quality of life improvement label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance A performance or quality of life improvement
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants