Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Reverend's themes - also - Okay in campaign properties edit updates token properties #3834

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Add Reverend's themes - also - Okay in campaign properties edit updates token properties #3834

merged 2 commits into from
Feb 16, 2023

Conversation

bubblobill
Copy link
Collaborator

@bubblobill bubblobill commented Feb 12, 2023

Description of the Change\

Add new theme(s) with various font sizes for visually impaired

Okay button in Campaign Properties dialog does "Update" of token properties.


This change is Reviewable

@Phergus
Copy link
Contributor

Phergus commented Feb 13, 2023

For future reference, do not mix fixes for unrelated issues under a single PR. Create a separate branch on your end for each and then submit as separate PRs.

You need to identify all issues that are related to this PR and make sure you have assigned them to yourself.

@bubblobill
Copy link
Collaborator Author

Addresses #3836
Adds theme and variations that is friendlier on the eyes and has different default font sizes

@bubblobill
Copy link
Collaborator Author

Because I am bad - also includes fix for #2405
Clicking okay in campaign properties now runs update() on token properties panel first.

@bubblobill bubblobill changed the title Reverend themes Add Reverend's themes - also - Okay in campaign properties edit updates token properties Feb 14, 2023
Copy link
Contributor

@Phergus Phergus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @bubblobill)

@Phergus Phergus merged commit 0fdbeca into RPTools:develop Feb 16, 2023
@bubblobill bubblobill deleted the Reverend_Themes branch February 21, 2023 04:29
@cwisniew cwisniew added the feature Adding functionality that adds value label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

3 participants