Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3833- Increased width of round counter label - added additional light details to getInfo #3835

Merged
merged 4 commits into from
Feb 16, 2023

Conversation

bubblobill
Copy link
Collaborator

@bubblobill bubblobill commented Feb 12, 2023

Requirements for Contributing a Bug Fix or Enhancement

Identify the Bug or Feature request

fixes #3833 - Increased width of round counter label


This change is Reviewable

@Phergus
Copy link
Contributor

Phergus commented Feb 13, 2023

This PR has multiple files unrelated to the stated purpose. Keep your work for issues in separate branches.

@bubblobill bubblobill changed the title Fixes #3833- Increased width of round counter label Fixes #3833- Increased width of round counter label - added additional light details to getInfo Feb 14, 2023
@Phergus Phergus merged commit 25dea79 into RPTools:develop Feb 16, 2023
@kwvanderlinde
Copy link
Collaborator

Is there an open FREQ for the getInfo() changes? The changes here are a little off and could have been discussed outside of a PR.

I'm going to be updating PR #3837 to account for the getInfo() changes as there is a conflict there. That will involve:

  1. Removing the newly added "shape" field as it's meaningless (LightSource.getShapeType() isn't used for anything). The actual shapes used by a light are already found under the "light segments" field. This is true regardless of the status of Add a lumens overlay and make lights environmental #3837.
  2. Moving the newlly added "lumens" field under "light segments" as well, as it won't belong to LightSource anymore. This is only true if Add a lumens overlay and make lights environmental #3837 is accepted.

@Phergus
Copy link
Contributor

Phergus commented Feb 16, 2023

That would be #3572 I believe.

@cwisniew cwisniew added the bug label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Bug 1.11.5+]: Initiative Tracker shows ... at round 10 and beyond
4 participants