Replace string comparisons with OverlayType enum in Token States #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No idea why the formatting checker errored. It has nothing to do with this PR I think. |
kwvanderlinde
approved these changes
Feb 27, 2023
|
Just clicked "approve" then remembered I wanted to ask one thing: what is the new dependency on Apache Commons BeanUtils for? |
It's needed at runtime to open the preferences dialog if you run MT outside of intellij. I removed it when I cleaned up the dependencies. You get a ClassNotFoundException otherwise. |
Phergus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fix #3844
Description of the Change
Replace string comparison with a proper OverlayType enum.
Release Notes
This change is