Refactor/3854 spotless for verification #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than running a dedicated google-java-format action, we now rely on spotless to do the invocation for us, so that it matches dev environments.
thelsing
approved these changes
Mar 11, 2023
Phergus
approved these changes
Mar 11, 2023
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @kwvanderlinde)
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Resolves #3854
Description of the Change
The googlejavaformat action is removed from the formatting PR verification step in favour of running
spotlessCheck. If the check fails, the PR verification will fail.I've also updated the spotless gradle plugin to the current latest version (6.16.0) while leaving the backend version of google-java-format where it was to avoid distracting formatting changes.
Possible Drawbacks
Shouldn't be any.
Documentation Notes
N/A
Release Notes
N/A
This change is