Fixes #3259 #3860
Merged
Fixes #3259 #3860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed all the regular expression related to MacroLinkFunction class to directly match the longest possible path in the macro path.
Phergus
approved these changes
Mar 12, 2023
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @emmebi)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed all the regular expression related to MacroLinkFunction class to directly match the longest possible path in the macro path.
Identify the Bug or Feature request
Fixes #3259
Description of the Change
The regular expressions used to parse the macro links didn't cope with the possibility to have forward slashes (
/) in the name of the macro. With the adds-on this is now a possibility, so I am extending the macro to match as much as possible in the macro URL to include also the folder names.I have added some test cases to test for possible cases. The tests are driven by a couple of CSV files, so if more test cases are needed, it should be easy to add them.
Possible Drawbacks
There could be other parts of the code which rely on the fact that there are no slashes in the macro name; while I tried to check all the patterns which could be relevant, it's entirely possible that I missed some.
Documentation Notes
N/A
Release Notes
This change is