Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sends the START_ASSET_TRANSFER_MSG through the same channel as the UPDATE_ASSET_TRANSFER_MSG #3886

Merged
merged 2 commits into from Mar 29, 2023

Conversation

emmebi
Copy link
Collaborator

@emmebi emmebi commented Mar 28, 2023

Fixes #3853

Identify the Bug or Feature request

As discussed in #3853, sometimes a client can get stuck during the download of a campaign.

Description of the Change

Following the suggestion from @sauliuskarmanovas, we send the START_ASSET_TRANSFER_MSG on the same channel as the UPDATE_ASSET_TRANSFER_MESSAGE to prevent that the messages referring to the same asset are received from the client in the wrong order.

Possible Drawbacks

None foreseen

Tests done

  • opened a campaign with 200+ asset, connected with a client (on the same LAN), the campaign was downloaded successfully

Documentation Notes

N/A

Release Notes

  • Fixed campaign stuck during download

This change is Reviewable

@cwisniew cwisniew merged commit 1d82251 into RPTools:develop Mar 29, 2023
4 checks passed
@cwisniew cwisniew added the bug label Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Map Loading Gets Stuck
2 participants