Update to Java 20 #3942
Merged
Update to Java 20 #3942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The required w/JDK 17 checks won't pass (expected) as it's moved to java 20. Once reviewed I will update the required branch checks to w/JD 20 so it can be merged. A lot of Java source files were changed as the upgrade to Java 20 required Google java format update as well, and it is no longer happy about /** */ documentation comments that are on a single line. |
kwvanderlinde
approved these changes
Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Resolves #3931
Description of the Change
Updates build to use Java 20
Possible Drawbacks
There could be issues due to changes in JVM.
Also the updated google java format required for Java 20 required changes in format to be applied with spotlessApply.
(its now strict about not using single line /** */ documentation comments.(
Documentation Notes
Update to use Java 20
Release Notes
This change is