Fixes for Hero Lab tokens #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
approved these changes
May 10, 2023
|
Thank you for working on this. I'll test it. |
|
Tested in MapTool-1.14.0-alpha.3.msi. I tested all of my use cases where this was previously a problem: starting up server and shutting down server (disconnecting from server).
Very good! Awesome! Fixed! Thank you!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #3591
Description of the Change
The Portfolio file was not in the DTO for hero lab data. This resulted in the value being lost on server start or transfer to clients.
Possible Drawbacks
Should be none
Release Notes
This change is