Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch generation of gui code from java to compiled classes #4103

Merged
merged 4 commits into from Jun 2, 2023

Conversation

thelsing
Copy link
Collaborator

@thelsing thelsing commented May 31, 2023

Requirements for Contributing a Bug Fix or Enhancement

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in timely manner will result in a request for you to update the pull request
    and possibly closure of the pull request if it is not provided after this request.
  • After you create the pull request, all status checks must pass before a maintainer will review your contribution.

Identify the Bug or Feature request

fixes #4053

Description of the Change

This adds a gradle plugin that adds generates the gui code from the form files into classes.
The autogenerated code was also removed from the *View classes. The $$$getRootComponent$$$ method was renamed to getRootComponent as it's not generated any more.

Possible Drawbacks

The downside is that this happens on every build. So you get exceptions because of duplicate methods in the class files.
As a workaround for this I added a deleteUiCLasses task that deletes all these classes and thus forces a rebuild of them.
The intellij option should set to "generated binary java classes" if you build with intellij to avoid readding the genrated java code.


This change is Reviewable

@thelsing thelsing changed the title Develop switch generation of gui code from java to compiled classes May 31, 2023
Copy link
Member

@cwisniew cwisniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If any of the dev flow needs changes, can you raise another issue with just a short description to remind one of us to update the documentation for new developers :)

build.gradle Show resolved Hide resolved
@cwisniew cwisniew added this pull request to the merge queue Jun 2, 2023
Merged via the queue into RPTools:develop with commit ee8a79f Jun 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Converting to IntelliJ GUI designer as broken build / development process
2 participants