Feature addon metadata #4167
Merged
Feature addon metadata #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture-addon-metadata
…maptool into feature-addon-metadata
| Asset asset = | ||
| Type.fromMediaType(mediaType) | ||
| .getFactory() | ||
| .apply(namespace + "/" + METADATA_DIR + path, bytes); |
There was a problem hiding this comment.
Is it intentional to add METADATA_DIR to path a second time here?
There was a problem hiding this comment.
Would you believe me if I said yes? No? yeah I wouldn't either...
I have updated so that the metadata dir doesn't get appended twice to the name of the asset
kwvanderlinde
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
resolves #4166
Description of the Change
Any files in the root of the mtlib zip file also get entries in the metadata/ directory
Possible Drawbacks
If someone has a metadata/ directory already that contains the same filename it will be overwritten
Documentation Notes
Files at the top level of the .mtlib zip file will be available lib:///metadata/
Release Notes
This change is