Ensure PackedFile is always closed and remove PackedFile.finalize() #4226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all `PackedFile` instances are wrapped in a try-with-resources to ensure they are always closed. The one exception guarantees the instance is closed in a `finally` block. The following places used to (at least partially) rely on PackedFile.finalize() but now use try-with-resources: - `ImageFileImagePanelModel.getDecorations()` - `PersistenceUtils.loadCampaignProperties()` - `PackedFile` The following place used to call `PackedFile.close()` in a `finally` block now uses try-with-resources: - `PersistenceUtil.loadCampaign()` The following place still uses a `finally` block because there is extra logic surrounding the close() call: - `PersistenceUtil.saveCampaign()`
kwvanderlinde
force-pushed
the
refactor/3948-remove-finalize
branch
from
d8fb5c2
to
eaa7f0e
Compare
cwisniew
approved these changes
Aug 1, 2023
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Implements #3948
Description of the Change
Almost all
PackedFileinstances are wrapped in a try-with-resources to ensure they are always closed. The one exception (PersistenceUtils.saveCampaign()) had logic around.close(), so I left that in itsfinallyblock instead of trying to rework it into try-with-resources.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
N/A
This change is