Work around the JavaFX NPE bug causing HTML5 listeners to not be called #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using a method reference creates a new `EventListener` instance each time rather than registering the same instance over and over. This works around the JavaFX 19 & 20 bug that generates a NPE while handling events.
cwisniew
approved these changes
Aug 24, 2023
kwvanderlinde
added a commit
to kwvanderlinde/maptool
that referenced
this pull request
Nov 30, 2023
HTML5 event listeners are now registered as before. However, to avoid peering issues in JavaFX <22, new listeners are created each time the page is unloaded.
kwvanderlinde
added a commit
to kwvanderlinde/maptool
that referenced
this pull request
Nov 30, 2023
HTML5 event listeners are now registered as before. However, to avoid peering issues in JavaFX <22, new listeners are created each time the page is unloaded.
kwvanderlinde
added a commit
to kwvanderlinde/maptool
that referenced
this pull request
Nov 30, 2023
HTML5 event listeners are now registered as before. However, to avoid peering issues in JavaFX <22, new listeners are created each time the page is unloaded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Should fix #4048
Description of the Change
There is a bug in JavaFX 19 & 20 where using the same
EventListenerinstance across different pages with the same WebView will result in an internal NPE that prevents theEventListenerfrom being called. This change works around that by always provided a new instance (via method reference) when registering the handler.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
N/A
This change is