Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Genesys Narrative Dice (incl StarWars) #4304

Merged
merged 7 commits into from
Sep 30, 2023
Merged

Conversation

cwisniew
Copy link
Member

@cwisniew cwisniew commented Sep 29, 2023

Identify the Bug or Feature request

Resolves #4303

Description of the Change

Usage
[ sw!'yyy' ] or [ sw!"yyy"] for starwars symbols
[ gs!'yyy' ] or [ gs!"yyy"] for standard genesys symbols

Valid values

y/yellow/pro/prof/proficiency
g/green/a/ab/abil/ability
b/blue/boo/bst/boost
blk/k/black/s/set/sb/setback
r/red/c/ch/challenge
p/purple/d/diff/difficulty
w/white/f/force
*/suc/success
v/adv/advantage
!/tri/triumph
-/fail/failure
t/thr/thrt/threat
$/des/despair
l/light/lf/lightpip/ls/lightforce
n/dark/df/darkpip/ds/darkforce

You can specify arguments by typing out the value multiple times

image
image

spaces aren't required, they just make it easier to read, likewise you can use commas to make things easier to read
image

All arguments also accept the number of dice in front of them
image

The roller also sets the following variables

sw.lastRoll.success.    -   The number of successes (success + those rolls that count as success)
sw.lastRoll.failure     -   The number of failures (failures + those rolls that count as failures)
sw.lastRoll.advantage   -   The number of advantages
sw.lastRoll.threat      -   The number of threats
sw.lastRoll.triumph     -   The number of triumphs
sw.lastRoll.despair     -   The number of despair
sw.lastRoll.light       -   The number of light force
sw.lastRoll.dark        -   The number of dark force

image

For genesys rolls its gs.lastRoll... (except light/dark are not set)
image

Any where you use a number you can use one of the following

{variableName}
{@propertyName}
{?User Prompt}

image
image
image

Capture groups are supported with (groupName: roll)
You can access the values with the variable sw.lastRoll.group.groupName... (all of the same values as above for lastRoll)
image

Note the result contains all the values in the capture groups, they are not excluded from it
You can also have capture groups within capture groups

image
although the variable names start to get really long 🙂

Possible Drawbacks

There is no tool tip support due to what you can wrap tool tips around in current implementation.
I am sure others will want this type of support for other dice rolls we currently have

Documentation Notes

See above

Release Notes

  • Genesys narrative dice supported (including starwars)

This change is Reviewable

@cwisniew cwisniew added the feature Adding functionality that adds value label Sep 29, 2023
@cwisniew cwisniew changed the title flesh out dice Add Genesys Narrative Dice (incl StarWars) Sep 29, 2023
@kwvanderlinde
Copy link
Collaborator

This seems to be good to me. I'm not familiar with these systems, though. Could it be important for, say, red dice to actually be coloured red in the results? Or are all the symbols unique so that doesn't matter?

@cwisniew
Copy link
Member Author

cwisniew commented Sep 30, 2023

This seems to be good to me. I'm not familiar with these systems, though. Could it be important for, say, red dice to actually be coloured red in the results? Or are all the symbols unique so that doesn't matter?

The overall result is what matters not so much the colour of the dice... This is all based on feedback in discord as I am not really familiar with it either, no one has asked for colouring of the dice so I think from that point of view we would be ok for initial go at it. Would it be nice to colour them, probably but that's going to need updates to chat to make it theme reactive first since there are also white and black dice

@cwisniew cwisniew added this pull request to the merge queue Sep 30, 2023
Merged via the queue into RPTools:develop with commit 043c840 Sep 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Genesys / FFG Starwars dice roller
2 participants