Refactor ZoneRenderer - initial steps #4384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move ZoneRender & ZoneRendererFactory to renderer package
This reverts commit 5ce220f.
Moved ZoneRenderer & ZoneRendererFactory to package. Moved subclasses/enums/etc out of ZoneRenderer and into package. Changed accesses from private to package-private where necessary.
kwvanderlinde
approved these changes
Nov 9, 2023
cwisniew
added
the
code-maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
First step for resolving #3691
Description of the Change
Move ZoneRenderer & ZoneRendererFactory to new package net.rptools.maptool.client.ui.zone.renderer
.
ZoneRenderer sub-classes split off to package classes
Possible Drawbacks
none
Documentation Notes
Refactor zone renderering into new package net.rptools.maptool.client.ui.zone.renderer.
Release Notes
N/A
This change is