Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n language files updated for new beam light type #4517

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

bubblobill
Copy link
Collaborator

@bubblobill bubblobill commented Dec 2, 2023

Requirements for Contributing a Bug Fix or Enhancement

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in timely manner will result in a request for you to update the pull request
    and possibly closure of the pull request if it is not provided after this request.
  • After you create the pull request, all status checks must pass before a maintainer will review your contribution.

Identify the Bug or Feature request

Description of the Change
Campaign properties dialog documentation for #4516
Improves #4448

Drawbacks

Identify the Bug or Feature request

Improves #4448
Builds on #4516

Description of the Change

i18n language files now match the options available with new light/sight shape type

Possible Drawbacks

None

Documentation Notes

N/A

Release Notes

N/A


This change is Reviewable

@kwvanderlinde
Copy link
Collaborator

This must have happened with the original line changes, but I've noticed that the translations for CampaignPropertiesDialog.label.light have duplicate Format: sections. Actually the first "duplicate" has some stuff mixed in from the sight help text (e.g., personal light syntax).

Can you remove that as part of this PR?

@bubblobill
Copy link
Collaborator Author

Did I fail at copy and paste? Shame on me.
Will fix

@bubblobill
Copy link
Collaborator Author

bubblobill commented Dec 3, 2023

Sorted, duplicated text removed.

@cwisniew cwisniew added the feature Adding functionality that adds value label Dec 7, 2023
@cwisniew cwisniew added this pull request to the merge queue Dec 7, 2023
Merged via the queue into RPTools:develop with commit bffb47d Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants