Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auras and Lights Through VBL #4579

Merged
merged 8 commits into from
Jan 2, 2024

Conversation

ColdAnkles
Copy link
Contributor

@ColdAnkles ColdAnkles commented Dec 22, 2023

Identify the Bug or Feature request

closes #4578

Description of the Change

Adds basic option in light campaign properties to allow auras/lights to phase through VBL.

Possible Drawbacks

Complicates future, more robust systems.

Documentation Notes

Adds "IGNORE-VBL" as option key in Campaign Light Properties for disabling VBL effect on lights/auras.

Release Notes

Added option for disabling VBL effects on lights/auras.


This change is Reviewable

@cwisniew cwisniew requested review from kwvanderlinde and bubblobill and removed request for kwvanderlinde December 23, 2023 09:41
@bubblobill
Copy link
Collaborator

No. PASSTHRU is a bad keyword. It's not a real word, it's bastardised bad English, which makes it harder to translate.
No objection to the functionality, I'm assuming there is a use-case which is why it was written, but it needs a better keyword.
Imagine someone with bad English trying to explain it to someone with no English.
"Unblocked" is better but there is probably a better word than that.

Copy link
Collaborator

@bubblobill bubblobill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar enough with light code to spot errors, but I see no holes in it.

…ion updates.

Removed Ignores VBL from SightSyntax.java as not wanted.
@ColdAnkles
Copy link
Contributor Author

I think I got all the required updates

@cwisniew cwisniew added this pull request to the merge queue Jan 2, 2024
Merged via the queue into RPTools:develop with commit b6bef7c Jan 2, 2024
4 checks passed
@bubblobill
Copy link
Collaborator

Damnit. I just had a thought. It should be IGNORES-VB
a) We need to stop sticking the L on the abbreviation when it is unnecessary, because, English, and
b) If His Majesty implements layering/elevation, there is a difference between VB & VBL,
Can you tweak the parser to accept VB as well as VBL?

@cwisniew
Copy link
Member

cwisniew commented Jan 2, 2024

Damnit. I just had a thought. It should be IGNORES-VB a) We need to stop sticking the L on the abbreviation when it is unnecessary, because, English, and b) If His Majesty implements layering/elevation, there is a difference between VB & VBL, Can you tweak the parser to accept VB as well as VBL?

If there are going to be layer groups, there would still be a layer in each group for vision blocking. Mind you VBL has been less than accurate since vision blocking could be included on tokens etc. But part of me just wonders if you are being sponsored by CUB in your quest to rebrand everything as VB :)

@bubblobill
Copy link
Collaborator

bubblobill commented Jan 2, 2024

Yes, but what if my light is to transcend layers? Then it's just a beer with no L
BTW. Help text and translation file has been updated to include this.

@ColdAnkles ColdAnkles deleted the pass-through-lights branch January 8, 2024 21:14
@cwisniew cwisniew added the feature Adding functionality that adds value label Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Auras and Light Through Walls
4 participants