Alternate Encoding Handling for Addon Content #4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, UTF16, or LATIN1 encodings of text files within addon files.
|
There is no need to try it as ASCII first as UTF8 decoder should read an ASCII file fine. Also not sure about ISO_8859_1 as we don't want to go down the path of supporting detecting and reading every character set out there, UTF 8 and 16 are enough (well more than enough really :) ) |
cwisniew
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
fixes #4594
Description of the Change
Adds an ugly try/catch chain that attempts to determine the encoding of the byte array instead of assuming UTF8
Possible Drawbacks
Only handles ASCII, UTF-8, UTF-16, or Latin1 - and doesn't read file if can't determine encoding (null).
Documentation Notes
Uses Standard Java Charset Decoding, assuming different encodings until it matches or fails entirely.
Release Notes
Added Encoding Checks for Addon File Import
This change is