Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reworked Token Type/Properties Editor tab #4653

Merged
merged 5 commits into from
Jan 21, 2024

Conversation

bubblobill
Copy link
Collaborator

@bubblobill bubblobill commented Jan 20, 2024

Resolves #4641

Description of the Change

  • Added help text for column headings.
  • Changed labels to textareas to allow wrapping of descriptions.
  • Added "Help" button that shows the help text (normally hidden).
  • Added "Copy" button to token type actions that duplicates selected type. (A nod towards bulk editing [Feature]: Adjust UI spacing in token properties and Include option for old style entry #4649)
  • Wrapped column names in HTML to allow text wrap.
  • Resized columns to be more appropriate.
  • Fiddled with trying to make the table pretty.
  • Checked on dark theme and large-print. Seems to work.
  • Refactored typo in getAllCompoments()
  • Alpha-sorted all the i18n button string keys

Pretty sure it is ready for testing in the wild.

Possible Drawbacks

People might not like it, I may have done something terribly wrong

Documentation Notes

Revamped token types and property editor.

Release Notes

Revamped token types and property editor.


This change is Reviewable

added some styling,
shuffled the column order,and
set columns to user resizable.
Changed labels to textareas to allow wrapping of descriptions.
Added "Help" button that shows the help text (normally hidden).
Checked on dark theme and large-print. Seems to work.
Added "Copy" button to token type actions that duplicates selected type.
Wrapped column names in HTML to allow text wrap.
Fiddled with trying to make the table pretty.
Alpha-sorted all the button string keys
@cwisniew cwisniew added this pull request to the merge queue Jan 21, 2024
@cwisniew cwisniew added the feature Adding functionality that adds value label Jan 21, 2024
Merged via the queue into RPTools:develop with commit eb34a2a Jan 21, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding functionality that adds value
Projects
Development

Successfully merging this pull request may close these issues.

[Refactoring]: Campaign Properties - Reworking Token Properties Edit Table
2 participants