Mark .form files as inputs to :instrumentForms task #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the class files to be reinstrumented when GUI designer changes are made. Previously tasks would all report as UP-TO-DATE, so changes would not be reflected in the next run.
|
This is a part of Gradle I'm not super familiar with. If anyone knows a more idiomatic way to grab the |
cwisniew
approved these changes
Feb 8, 2024
cwisniew
added
the
code-maintenance
kwvanderlinde
deleted the
refactor/4389-reinstrument-on-form-file-changes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Improves on PR #4390 for #4389
Description of the Change
I've noticed that the current
:instrumentFormstask does not recognize changes to IntelliJ GUI files. This makes dev iteration more clunky than it needs to be when making frequent UI changes. So the situation was only mildly improved by the previous PR.This PR makes it so the class files are reinstrumented whenever a
.formfile is changed. This way they won't report as up-to-date unless neither Java nor form files are modified.Possible Drawbacks
Should be none (build only).
Documentation Notes
N/A
Release Notes
N/A
This change is