Fix rendering of line cell templates #4752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`calcPath()` has been simplified to essentially Bressenham's algorithm. It only calculates and returns a path, while `getPath()` (previously unused) will call it if needed. `getBounds()` now correctly accounts for the path's quadrant and the position of the first vertex to produce a correctly located and sized bounding box. This method was also simplified to only look at the two endpoints rather than iterating over the entire line. All fields except `pathVertex` are now marked as `transient` since they can be recovered from only `getVertex()` and `pathVertex`. Correspondingly, the quadrant is not longer part of the DTO, and the serialized XML is much smaller. With the above changes in, it was natural to simplify `LineCellTemplateTool` to avoid a lot of case work, especially in not relying on mutations of `getPathVertex()`.
kwvanderlinde
force-pushed
the
bugfix/3692-line-cell-template-fix
branch
from
2f3bac8
to
6de6d88
Compare
cwisniew
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #3692
Description of the Change
This PR fixes the calculation of the bounding box for
LineCellTemplatewhich stops it from being cut off depending on the viewport.Also spent some time simplifying a few things while I tried to diagnose the underlying issue:
LineCellTemplateis a bit more encapsulated now. E.g., it now manages its own quadrant rather than requiring the tool to figure that out.LineCellTemplatefields aside frompathVertexare now markedtransientas they can be recalculated any time. Excluding<path>and<pool>from the XML significantly reduces its size.calcPath()is now Bressenham's algorithm which requires less casework.getBounds()now only checks the first and last points in the path, rather than checking all points for the smallest values.Possible Drawbacks
Should be none.
Documentation Notes
N/A
Release Notes
This change is