Handle NPE when grid tool is open and map is removed #4754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwvanderlinde
force-pushed
the
bugfix/4523-npe-when-adjust-grid-is-open-and-map-disappears
branch
from
d262fe6
to
3edc428
Compare
…and-map-disappears
cwisniew
approved these changes
Apr 16, 2024
kwvanderlinde
deleted the
bugfix/4523-npe-when-adjust-grid-is-open-and-map-disappears
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
Fixes #4523
Description of the Change
When the Adjust Grid tool is detached from a zone, it first attempts to write out its state to the zone. This doesn't work if the zone is being removed since the zone is likely to be gone by the time the updated is received. So we now check in the message handlers whether the zone is still around before applying the updates.
Possible Drawbacks
Should be none
Documentation Notes
N/A
Release Notes
This change is