Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setTableEntry() performance #4770

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

Commits on Feb 17, 2024

  1. Update nightly-publish.yml

    Disabled nightly build by changing an element that would normally schedule a job.
    Azhrei committed Feb 17, 2024
    Configuration menu
    Copy the full SHA
    ee9a535 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5f64a3a View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Configuration menu
    Copy the full SHA
    f4eff04 View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Configuration menu
    Copy the full SHA
    143be39 View commit details
    Browse the repository at this point in the history
  2. Fixup of setTableEntry performance

    FullBleed complained on Discord about the performance of this MTscript
    function.  It turns out that the algorithm is O(n), so putting 3200
    entries in a table gets seriously slow.  Fixing this will require the
    supporting `LookupTable` class to have its own `setTableEntry` method.
    This commit is some simpler formatting and refactoring fixes; the next
    commit will be more substantial in regards to the actual fix.
    Azhrei committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e1796d2 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Configuration menu
    Copy the full SHA
    be5e5d6 View commit details
    Browse the repository at this point in the history
  2. Unit tests and performance fixes for LookupTable

    Part 1, laying the groundwork by adding documentation and correcting
    warnings in the affected file(s).  WIP.
    Azhrei committed May 9, 2024
    Configuration menu
    Copy the full SHA
    d2ac3a4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    68912c8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    21c2c77 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. Continue with updating LookupTable

    Finished adding tests of the model.  I'm not thrilled with the
    ExpressionParser class being used directly by LookupTable, but changing
    it to use DI is beyond the scope of this issue.  When the LookupTable
    changes its implementation to a sorted array, the dependency can be
    changed (perhaps).
    
    Should the MTscript functions have tests as well?  Or should those be
    done via a macro within the tool?  It would certainly be easier to
    automate if they were in Java, but putting a bunch of testing macros
    into a campaign would (potentially) allow others to build tests as well
    and contribute to the project.
    
    (TODO) With the use of `macro.catch`, maybe exceptions thrown within
    MTscript can actually be caught and handled in a sufficient way?
    Azhrei committed May 14, 2024
    Configuration menu
    Copy the full SHA
    391f073 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2024

  1. Removed redundant call

    Azhrei committed May 26, 2024
    Configuration menu
    Copy the full SHA
    967afa7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7b74dc4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a78d49f View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3b3ba7d View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2efe7fc View commit details
    Browse the repository at this point in the history
  6. Ran spotlessApply

    Azhrei committed May 26, 2024
    Configuration menu
    Copy the full SHA
    5eb4b75 View commit details
    Browse the repository at this point in the history
  7. Revert "Update nightly-publish.yml"

    This reverts commit ee9a535.
    Azhrei committed May 26, 2024
    Configuration menu
    Copy the full SHA
    6ee6f56 View commit details
    Browse the repository at this point in the history
  8. Revert "Fixup of setTableEntry performance"

    This reverts commit e1796d2.
    Azhrei committed May 26, 2024
    Configuration menu
    Copy the full SHA
    1fee87e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    973dd4e View commit details
    Browse the repository at this point in the history