-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix setTableEntry()
performance
#4770
Open
Azhrei
wants to merge
19
commits into
RPTools:develop
Choose a base branch
from
Azhrei:fb-table-speed
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Feb 17, 2024
-
Disabled nightly build by changing an element that would normally schedule a job.
Configuration menu - View commit details
-
Copy full SHA for ee9a535 - Browse repository at this point
Copy the full SHA ee9a535View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f64a3a - Browse repository at this point
Copy the full SHA 5f64a3aView commit details
Commits on Mar 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f4eff04 - Browse repository at this point
Copy the full SHA f4eff04View commit details
Commits on Apr 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 143be39 - Browse repository at this point
Copy the full SHA 143be39View commit details -
Fixup of setTableEntry performance
FullBleed complained on Discord about the performance of this MTscript function. It turns out that the algorithm is O(n), so putting 3200 entries in a table gets seriously slow. Fixing this will require the supporting `LookupTable` class to have its own `setTableEntry` method. This commit is some simpler formatting and refactoring fixes; the next commit will be more substantial in regards to the actual fix.
Configuration menu - View commit details
-
Copy full SHA for e1796d2 - Browse repository at this point
Copy the full SHA e1796d2View commit details
Commits on May 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for be5e5d6 - Browse repository at this point
Copy the full SHA be5e5d6View commit details -
Unit tests and performance fixes for LookupTable
Part 1, laying the groundwork by adding documentation and correcting warnings in the affected file(s). WIP.
Configuration menu - View commit details
-
Copy full SHA for d2ac3a4 - Browse repository at this point
Copy the full SHA d2ac3a4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68912c8 - Browse repository at this point
Copy the full SHA 68912c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 21c2c77 - Browse repository at this point
Copy the full SHA 21c2c77View commit details
Commits on May 14, 2024
-
Continue with updating LookupTable
Finished adding tests of the model. I'm not thrilled with the ExpressionParser class being used directly by LookupTable, but changing it to use DI is beyond the scope of this issue. When the LookupTable changes its implementation to a sorted array, the dependency can be changed (perhaps). Should the MTscript functions have tests as well? Or should those be done via a macro within the tool? It would certainly be easier to automate if they were in Java, but putting a bunch of testing macros into a campaign would (potentially) allow others to build tests as well and contribute to the project. (TODO) With the use of `macro.catch`, maybe exceptions thrown within MTscript can actually be caught and handled in a sufficient way?
Configuration menu - View commit details
-
Copy full SHA for 391f073 - Browse repository at this point
Copy the full SHA 391f073View commit details
Commits on May 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 967afa7 - Browse repository at this point
Copy the full SHA 967afa7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b74dc4 - Browse repository at this point
Copy the full SHA 7b74dc4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a78d49f - Browse repository at this point
Copy the full SHA a78d49fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b3ba7d - Browse repository at this point
Copy the full SHA 3b3ba7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2efe7fc - Browse repository at this point
Copy the full SHA 2efe7fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5eb4b75 - Browse repository at this point
Copy the full SHA 5eb4b75View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ee6f56 - Browse repository at this point
Copy the full SHA 6ee6f56View commit details -
Revert "Fixup of setTableEntry performance"
This reverts commit e1796d2.
Configuration menu - View commit details
-
Copy full SHA for 1fee87e - Browse repository at this point
Copy the full SHA 1fee87eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 973dd4e - Browse repository at this point
Copy the full SHA 973dd4eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.