Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rxc density plots and parallelization cluster making #122

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hikari-murayama
Copy link
Collaborator

Thanks for opening a PR!

  • [x ] Have you followed the guidelines in our Contributing Guide?
  • [x ] Ensured you are not committing large data files or other sensitive information (e.g. voter files)

Please list any Issues this PR addresses

In 2-3 sentences or a brief list, describe changes implemented in this PR

  • Adds a time out for parallelization (keep for now as need to update to most recent version of R to not get an error)
  • Changed column names for rxc plotting

@hikari-murayama hikari-murayama changed the title Rxc parallel Rxc density plots and parallelization cluster making Sep 4, 2020
@lorenc5
Copy link
Collaborator

lorenc5 commented Sep 4, 2020

This just hung for like an hour, and produced one plot, pct_husted_pct_spiegel_hisp.png. So something is getting caught there. I ran it with par_computer=T and same thing. Thoughts?

@hikari-murayama
Copy link
Collaborator Author

I think part of the reason it's taking so long is that there are significantly more points the rxc chains have compared to ei. On the server it takes ~50 minutes to create one plot. But I'd need to take a closer look to see if anything is caught.

The plotting portion doesn't currently have a parallel option but that can definitely be implemented seeing how this takes so long.

@lorenc5
Copy link
Collaborator

lorenc5 commented Sep 4, 2020

What about the possibility that the user specify the comparison(s) they want, e.g.: pct_husted vs. pct_montanez? Instead of having the function loop through all the possible comparisons. Just a thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ei_rxc() plots=T doesn't produce density plots Making clusters for parallelized functions
2 participants