Fixed running docker script from within pwd containing spaces #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used the default
/dev/null:/dev/nullmount so the strings passed to thedocker runinvocation could stay tidy. This should have no impact on the process.I also added
-e IMG_NAME=${IMG_NAME}to allowIMG_NAMEto be passed on the command line when invoking the script, since this one variable is usually the single variable that gets changed. This is partly because the script checks that the variable is set, but not where it comes from (if you specify the variable on the command line, it gets caught a lot later inside the docker container)This also allows basic running of the image builder without needing to create a config file.
This pull request partly addresses #75, at least for the docker build.