Draft: fix nested vec serialization #199
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienr
force-pushed
the
fix-nested-vec-serialization
branch
from
67112f8
to
058e164
Compare
|
@RReverser do you think @julienr fix is OK? |
|
I moved to a custom serializer for other reasons, so pushing my fix isn't a
priority for me. But if someone wants to test and summit it, go ahead.
…On Tue, Apr 25, 2023, 13:32 Christopher Drews ***@***.***> wrote:
I have the same issue like in #186
<#186>. The fix from
@julienr <https://github.com/julienr> also works great for me. Would be
awesome if this could be released soon.
Please let me know if I can support to speed things up.
—
Reply to this email directly, view it on GitHub
<#199 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAD3V2TFWUIDRAZ6K4NOCPTXC6Y5RANCNFSM6AAAAAAVPO5ERE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sorry, but I gave rights to @punkstarman to maintain this repo a while ago. |
|
See quick_xml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #186 . Although the fix seems to work, I haven't fully understood why and so I'm not sure if it's the right fix or not.
I feel some additional serialization test cases should be added to robustify this part.