Support more types #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Can you rebase this so all the noise from the error_chain PR is removed? |
|
Yes |
farodin91
force-pushed
the
support-more-types
branch
from
56165c7
to
f7e1a5b
Compare
oli-obk
requested changes
Aug 18, 2017
src/lib.rs
Outdated
| self.read_inner_value::<V, _>(|this| { | ||
| if let XmlEvent::EndElement { .. } = *this.peek()? { | ||
| return Err(ErrorKind::Custom(format!("expected an integer")).into()); | ||
| return Err( | ||
| ErrorKind::Custom("Doesn't expected end element".to_string()).into(), |
There was a problem hiding this comment.
That's fairly obvious. Maybe state that a number was expected?
There was a problem hiding this comment.
It could be a number or boolean
There was a problem hiding this comment.
Right. Just list both of these.
There was a problem hiding this comment.
I found a solution
Merged
farodin91
force-pushed
the
support-more-types
branch
from
f7e1a5b
to
ee70164
Compare
oli-obk
approved these changes
Aug 18, 2017
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on error_chain PR #19