Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Format all the code base with black #9

Merged
merged 5 commits into from
Mar 6, 2022
Merged

Format all the code base with black #9

merged 5 commits into from
Mar 6, 2022

Conversation

jond01
Copy link
Collaborator

@jond01 jond01 commented Feb 20, 2022

Add black as a dev-dependency and run:

black .

Until we incorporate the formatting check in the CI, the PRs should respect the formatting by running the above manually.

@jond01 jond01 mentioned this pull request Feb 20, 2022
Open
5 tasks
elazarcoh
elazarcoh reviewed Feb 28, 2022
View reviewed changes
Copy link
Collaborator

@elazarcoh elazarcoh left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I think a line-breaking comment deserves a line for itself, so simple assignments won't get cluttered

medio/backends/itk_io.py Outdated Show resolved Hide resolved
medio/backends/itk_io.py Outdated Show resolved Hide resolved
medio/backends/itk_io.py Outdated Show resolved Hide resolved
medio/metadata/affine.py Outdated Show resolved Hide resolved
tests/itk_dcm_orientations/itk_utils.py Outdated Show resolved Hide resolved
@elazarcoh elazarcoh merged commit d7dac3c into RSIP-Vision:master Mar 6, 2022
@jond01 jond01 deleted the chore/modernize/black branch March 6, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elazarcoh elazarcoh elazarcoh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jond01 @elazarcoh